-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ideation endpoints to remove redundant teamId params #175
Conversation
Fixed unit tests, ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests passed, and revised routes worked on swagger. I also appreciated your thorough explanation of how the teamId and teamMemberId were queried - I did not see those connections when I was attempting this!
Description
Remove teamId params from
PATCH /voyages/ideations/{ideationId}
DELETE /voyages/ideations/{ideationId}
PATCH /voyages/ideations/{ideationId}/ideation-votes
DELETE /voyages/ideations/{ideationId}/ideation-votes
Issue link
https://app.clickup.com/t/86b0ump7x
Type of change
How Has This Been Tested?
Tested manually on swagger and ran
yarn test:docker
Checklist: