Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ideation endpoints to remove redundant teamId params #175

Merged
merged 9 commits into from
Jul 12, 2024

Conversation

cherylli
Copy link
Contributor

@cherylli cherylli commented Jul 10, 2024

Description

Remove teamId params from
PATCH /voyages/ideations/{ideationId}
DELETE /voyages/ideations/{ideationId}
PATCH /voyages/ideations/{ideationId}/ideation-votes
DELETE /voyages/ideations/{ideationId}/ideation-votes

Issue link

https://app.clickup.com/t/86b0ump7x

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested manually on swagger and ran yarn test:docker

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

@cherylli cherylli self-assigned this Jul 10, 2024
@cherylli cherylli marked this pull request as ready for review July 10, 2024 12:41
@cherylli
Copy link
Contributor Author

Fixed unit tests, ready for review

@cherylli cherylli requested review from curtwl, JoshuaHinman, timDeHof and Ajen07 and removed request for curtwl and JoshuaHinman July 10, 2024 12:45
Copy link
Contributor

@curtwl curtwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@JoshuaHinman JoshuaHinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests passed, and revised routes worked on swagger. I also appreciated your thorough explanation of how the teamId and teamMemberId were queried - I did not see those connections when I was attempting this!

@cherylli cherylli merged commit b06e997 into dev Jul 12, 2024
1 check passed
@cherylli cherylli deleted the refactor/ideation branch July 12, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants